From 72062edbf51b30738227be8e639edb4f23306ea5 Mon Sep 17 00:00:00 2001 From: Enno Tensing Date: Tue, 22 Jul 2025 16:15:47 +0200 Subject: [PATCH] generate: container: Fix some issues reported by pylint This fixes various issues reported by pylint. It now only reports to issues, that can be ignored, since they're only about too many local variables or class attributes. Signed-off-by: Enno Tensing --- generate/container.py | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/generate/container.py b/generate/container.py index 9cc2eda..df6d21d 100644 --- a/generate/container.py +++ b/generate/container.py @@ -17,7 +17,7 @@ class ConfigError(Exception): def __init__(self, message: str = "") -> None: """Create Exception object.""" self.message = message - self.super.__init__(message) + super().__init__(message) def __str__(self) -> str: """Convert Exception object to a string.""" @@ -57,7 +57,7 @@ def trim(s: str) -> str: """Remove sequential whitespace.""" s = s.replace("\t ", "\t") s = s.replace("\t\\\n", " ") - while s.__contains__(" "): + while " " in s: s = s.replace(" ", " ") return s @@ -236,10 +236,15 @@ class Ports: def command(self) -> str: """Option for podman container create.""" ports = "" - for port in self.tcp_ports: - ports += f"\t--port {port}/tcp \\\n" - for port in self.udp_ports: - ports += f"\t--port {port}/udp \\\n" + seperator = " \\\n" + ports += seperator.join( + [f"\t--port {port}/tcp" for port in self.tcp_ports] + ) + ports += seperator + ports += seperator.join( + [f"\t--port {port}/udp" for port in self.udp_ports] + ) + ports += seperator return ports @@ -447,7 +452,7 @@ class Container: def create_container(self) -> str: """Generate podman container create command.""" - cmd = f"# Create container {self.name}" + cmd = f"# Create container {self.name}\n" cmd += "podman container crate \\\n" cmd += f"\t--name={self.name} \\\n" if self.privileged: